London | May-26 | Shahriar Ahmed | Sprint 1 | Form Controls#1243
Open
SABuilds wants to merge 23 commits into
Open
London | May-26 | Shahriar Ahmed | Sprint 1 | Form Controls#1243SABuilds wants to merge 23 commits into
SABuilds wants to merge 23 commits into
Conversation
…r" and "size of tshirt". added new option element so no size is selected as default
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SABuilds
added
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 14, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done. The code looks good and fulfills the requirements. Good job on using single commits for each change. It makes it easier to follow and single commits are also easier to undo if needed
Comment on lines
+7
to
+18
| #red { | ||
| height: 24px; | ||
| width: 24px; | ||
| } | ||
| #blue { | ||
| height: 24px; | ||
| width: 24px; | ||
| } | ||
| #purple { | ||
| height: 24px; | ||
| width: 24px; | ||
| } No newline at end of file |
There was a problem hiding this comment.
The css is the same for all 3 radio buttons. How could you use less code to achieve the same effect to be applied to all buttons?
Author
There was a problem hiding this comment.
Instead of using id for each one, I could put them into one class and reference that to style the radio.
Luro91
removed
the
Needs Review
Luro91
added
Complete
…ng the class as opposed to each element
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist:
Changelist
I created the form and met the requirements listed. I have tested the accessibility using lighthouse and I have got a score of 100. To summarise my changes, I created a dropdown menu for the sizes, I created a radio for the colours and, I created inputs for email and password. I utilised prettier to keep my code formatted and I utilised live server so I could utilise lighthouse.